f09ae248f9
* add staging ios app build script * feat(api): add OpenTelemetry LGTM stack for local observability Wire OTel traces, metrics, and logs through a collector to Tempo, Prometheus, and Loki, with custom LLM instrumentation, dev compose overlay, Grafana provisioning, env templates, and development.sh auto-start. * feat: expand observability, harden dev tooling, and fix expo staging UX Add business and LLM Prometheus metrics with Grafana dashboards, alerting, and a metrics verification script. Wire telemetry through adapters and core LLM paths, and document the local LGTM workflow. Fix development.sh for macOS bash 3.2, open Grafana and eval-web in Chrome, and repair eval-web auto-open (unbound EVAL_WEB_BROWSER_SCHEDULED). Merge internal-eval into the main dev script with improved compose handling. Require EXPO_PUBLIC_* at build time, improve iOS HTTP ATS for staging IPs, show memoir empty state instead of load errors when no chapters exist, and add jest env setup plus chapter list response normalization. * chore: enable Grafana Assistant Cursor plugin * fix: memoir empty state and repair withdrawn 0020_chapters_book_id stamp Show empty memoir UI when the chapter list succeeds with no items; treat auth/404 as non-fatal. Extend alembic revision repair so local dev DBs stamped with the removed 0020_chapters_book_id migration can roll back and upgrade to 0019. --------- Co-authored-by: Kevin <kevin@brighteng.org> Co-authored-by: Cursor <cursoragent@cursor.com>
72 lines
2.6 KiB
TypeScript
72 lines
2.6 KiB
TypeScript
import { ApiError, AuthError, NetworkError } from '@/core/api/types';
|
|
import {
|
|
isChapterListAuthError,
|
|
isChapterListEmptySuccess,
|
|
isChapterListNotFoundError,
|
|
normalizeChapterList,
|
|
shouldShowChapterListLoadError,
|
|
} from '@/features/memoir/chapter-list-response';
|
|
import type { Chapter } from '@/features/memoir/types';
|
|
|
|
describe('normalizeChapterList', () => {
|
|
it('returns empty array for nullish or non-array payloads', () => {
|
|
expect(normalizeChapterList(null)).toEqual([]);
|
|
expect(normalizeChapterList(undefined)).toEqual([]);
|
|
expect(normalizeChapterList({ items: [] })).toEqual([]);
|
|
});
|
|
|
|
it('passes through chapter arrays', () => {
|
|
const chapters = [{ id: 'ch-1' }] as Chapter[];
|
|
expect(normalizeChapterList(chapters)).toBe(chapters);
|
|
});
|
|
});
|
|
|
|
describe('isChapterListNotFoundError', () => {
|
|
it('detects ApiError 404', () => {
|
|
expect(isChapterListNotFoundError(new ApiError('missing', 404))).toBe(true);
|
|
expect(isChapterListNotFoundError(new ApiError('bad', 500))).toBe(false);
|
|
expect(isChapterListNotFoundError(new Error('other'))).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('isChapterListEmptySuccess', () => {
|
|
it('is true only for successful empty arrays', () => {
|
|
expect(isChapterListEmptySuccess(true, [])).toBe(true);
|
|
expect(isChapterListEmptySuccess(true, [{ id: 'x' } as never])).toBe(
|
|
false,
|
|
);
|
|
expect(isChapterListEmptySuccess(false, [])).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('isChapterListAuthError', () => {
|
|
it('treats AuthError and 401/403 ApiError as auth errors', () => {
|
|
expect(isChapterListAuthError(new AuthError())).toBe(true);
|
|
expect(isChapterListAuthError(new ApiError('unauthorized', 401))).toBe(true);
|
|
expect(isChapterListAuthError(new ApiError('forbidden', 403))).toBe(true);
|
|
expect(isChapterListAuthError(new ApiError('server', 500))).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('shouldShowChapterListLoadError', () => {
|
|
it('hides load error for empty success, 404, and auth failures', () => {
|
|
expect(shouldShowChapterListLoadError(null, true, 0)).toBe(false);
|
|
expect(shouldShowChapterListLoadError(new ApiError('nope', 404), false, 0)).toBe(
|
|
false,
|
|
);
|
|
expect(shouldShowChapterListLoadError(new AuthError(), false, 0)).toBe(false);
|
|
expect(
|
|
shouldShowChapterListLoadError(new ApiError('unauthorized', 401), false, 0),
|
|
).toBe(false);
|
|
});
|
|
|
|
it('shows load error for network and server failures', () => {
|
|
expect(
|
|
shouldShowChapterListLoadError(new NetworkError('offline'), false, 0),
|
|
).toBe(true);
|
|
expect(
|
|
shouldShowChapterListLoadError(new ApiError('boom', 500), false, 0),
|
|
).toBe(true);
|
|
});
|
|
});
|